Skip to content

Add multi-type support to set_preference #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
freekode merged 1 commit into from
Apr 17, 2020
Merged

Add multi-type support to set_preference #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions roomba/roomba.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,9 +309,13 @@ def send_command(self, command, params=None):

def set_preference(self, preference, setting):
self.log.debug("Set preference: %s, %s", preference, setting)
val = False
if setting.lower() == "true":
val = True
val = setting
# Parse boolean string
if isinstance(setting, str):
if setting.lower() == "true":
val = True
elif setting.lower() == "false":
val = False
tmp = {preference: val}
roomba_command = {"state": tmp}
str_command = json.dumps(roomba_command)
Expand Down