Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix status filtering #28

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix status filtering #28

wants to merge 4 commits into from

Commits on Jan 23, 2020

  1. Add .idea/ to .gitignore 

    Ignore JetBrains IDE-generated files.
    @jon-rtr
    jon-rtr committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    3f089af View commit details
    Browse the repository at this point in the history

  2. Run black formatter over code 

    Run the black formatter over the code.
    @jon-rtr
    jon-rtr committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    ab3c7a8 View commit details
    Browse the repository at this point in the history

  3. Remove Python 2 support 

    As of 2020 Jan 01, official support for Python 2 has ended (https://www.python.org/doc/sunset-python-2/, https://python3statement.org/).

* Remove `from __future__ import absolute_import` statement.
* Remove `from __future__ import unicode_literals` statement.
* Remove `from __future__ import print_function` statement.
* Remove `from urlparse import urljoin` statement, and retain the Python
3 equivalent.
* Switch to using format strings.
* BUGFIX: Per https://docs.rundeck.com/docs/api/rundeck-api.html#bulk-delete-executions, the url in the bulk_delete_executions function should look like `{}/executions/delete`, not `{}/executions/{}/delete`.
    @jon-rtr
    jon-rtr committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    37f1453 View commit details
    Browse the repository at this point in the history

  4. Fix status filtering 

    From rundeck/rundeck#1923:
> I've traced the issue down to the Content-Type header that messes up the whole request (It's not needed for a GET anyway, was there from a previous POST). The output is still a XML, I'll open a different issue for that

There are a few posts saying the same thing: GET requests specifying a
Content-Type header causes the URL parameters to be ignored.
    @jon-rtr
    jon-rtr committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    1206893 View commit details
    Browse the repository at this point in the history