ES8388 setInputVolume() Calculation

[ki6syd]

I was wondering if you might be able to explain the logic in AudioDriverES8388Class for setInputVolume(), or maybe there is a bug?

It looks like setInputVolume() with an input integer from 0 to 100 results in a call to es8388_set_mic_gain() with es_mic_gain_t values that don't use the full 0 to +24dB analog gain, since the enum definitions have assignments in units of dB. Is there a reason that the ES8388 class divides by 10 rather than mapping 0-100% to 0-24_dB and then casting as es_mic_gain_t scaling?

Thanks!

Max

[pschatzmann]

Confirmed, it is a bug: I committed a correction.

[ki6syd]

Thanks for addressing that quickly!

[ki6syd]

@pschatzmann, reviving an old thread here...wanted to give a heads-up that I think there is an issue in line 825 of the file you linked above.

It is currently:

int idx = limitValue(volume / 10, 9);

But I believe it should be as follows:

int idx = limitValue(volume / 10, 0, 9);

[pschatzmann]

You are right - I committed a correction: the next time I suggest that you submit a pull request...

[ki6syd]

Sounds good, will do!