-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip rendering the table if there are no updates to display #46
Conversation
Create a type for the style choice. Cleanup some of the test code.
+1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR!
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 66 67 +1
=========================================
+ Hits 66 67 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cool thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please add the nestif linter to the exclude list in https://github.com/psampaz/go-mod-outdated/blob/master/.golangci.yml#L45
These are the last changes and then we can merge it. Thanks again for your time! |
Co-authored-by: psampaz <[email protected]>
I've opened #50 for this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
In my usecase I'd like to only see output if there is an update to perform.
This change skips running the table rendering if the filtered modules is an empty slice.