Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip rendering the table if there are no updates to display #46

Merged
merged 6 commits into from
Jul 12, 2021

Conversation

Deseao
Copy link
Contributor

@Deseao Deseao commented Apr 28, 2021

In my usecase I'd like to only see output if there is an update to perform.
This change skips running the table rendering if the filtered modules is an empty slice.

@anedumgottil
Copy link

+1

Copy link
Owner

@psampaz psampaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!

internal/runner/runner_test.go Outdated Show resolved Hide resolved
internal/runner/runner.go Outdated Show resolved Hide resolved
internal/runner/runner_test.go Outdated Show resolved Hide resolved
internal/runner/runner_test.go Outdated Show resolved Hide resolved
internal/runner/runner_test.go Outdated Show resolved Hide resolved
internal/runner/runner_test.go Outdated Show resolved Hide resolved
internal/runner/runner_test.go Outdated Show resolved Hide resolved
internal/runner/runner_test.go Outdated Show resolved Hide resolved
@Deseao Deseao requested a review from psampaz June 16, 2021 17:26
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #46 (4ff0e39) into master (727b75a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #46   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           66        67    +1     
=========================================
+ Hits            66        67    +1     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/runner/runner.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da89f8c...4ff0e39. Read the comment docs.

@psampaz
Copy link
Owner

psampaz commented Jun 16, 2021

cool thanks!

Copy link
Owner

@psampaz psampaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal/runner/runner.go Show resolved Hide resolved
internal/runner/runner_test.go Outdated Show resolved Hide resolved
internal/runner/runner.go Show resolved Hide resolved
internal/runner/runner.go Show resolved Hide resolved
@psampaz
Copy link
Owner

psampaz commented Jun 16, 2021

These are the last changes and then we can merge it. Thanks again for your time!

@Deseao
Copy link
Contributor Author

Deseao commented Jun 16, 2021

Also please add the nestif linter to the exclude list in https://github.com/psampaz/go-mod-outdated/blob/master/.golangci.yml#L45

I've opened #50 for this

@Deseao Deseao requested a review from psampaz June 16, 2021 19:59
Copy link
Owner

@psampaz psampaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@psampaz psampaz merged commit f2740e9 into psampaz:master Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants