Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate templates from markdown to github forms #483

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

israpps
Copy link
Member

@israpps israpps commented Aug 9, 2021

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK
  • Requires update of the gsKit
  • Others (please specify below)

Pull Request description

migrate issue & FR templates from markdown to github forms.

  • looks better
  • you can create mandatory fields
  • whoever makes the issue or FR won't be able to manipulate the template original structure

@AKuHAK
Copy link
Member

AKuHAK commented Aug 10, 2021

Are you using editorconfig? Cause your files are full of blank spaces at the end of lines, also you miss leading return at the end of one file. I ask because editorconfig plugin will fix it for you.
Also issue-report..yml has doubledot in filename.
And I think that you can safely remove markdown issue template instead of saving backup. Backup can always be populated from git history

@israpps
Copy link
Member Author

israpps commented Aug 10, 2021

Are you using editorconfig? Cause your files are full of blank spaces at the end of lines, also you miss leading return at the end of one file. I ask because editorconfig plugin will fix it for you.
Also issue-report..yml has doubledot in filename.
And I think that you can safely remove markdown issue template instead of saving backup. Backup can always be populated from git history

Made it on my cellphone, maybe that's why...
I'll delete markdown then

@AKuHAK AKuHAK force-pushed the mardown2forms branch 2 times, most recently from 7bb8d47 to a8203b9 Compare August 10, 2021 21:29
@AKuHAK
Copy link
Member

AKuHAK commented Aug 10, 2021

Ok, I merged all commits, fixed formatting, added more text into a disclaimer, fixed grammar a bit, removed non-valid coexistence:
assignees cannot be null just removed it
validations cannot be used with checkboxes
placeholders are not used with values, left only values.
@israpps if you are fine with my changes, let me know

@israpps
Copy link
Member Author

israpps commented Aug 10, 2021

Ok, I merged all commits, fixed formatting, added more text into a disclaimer, fixed grammar a bit, removed non-valid coexistence:
assignees cannot be null just removed it
validations cannot be used with checkboxes
placeholders are not used with values, left only values.
@israpps if you are fine with my changes, let me know

No problem!
do as you want.

@AKuHAK AKuHAK merged commit 955c98d into ps2homebrew:master Aug 10, 2021
AKuHAK added a commit that referenced this pull request Sep 30, 2021
migrate templates from markdown to github forms
@israpps israpps deleted the mardown2forms branch August 15, 2022 17:35
citronalco pushed a commit to citronalco/OPL-Daily-Builds that referenced this pull request Sep 10, 2023
migrate templates from markdown to github forms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants