-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Controller Settings to menu #459
Conversation
This would be a good place for PADEMU also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, code-wise
I'll just rebase the codacy commit |
|
Not quite sure what is currently wrong with this PR? It uses only global settings and ignores per game settings? If it is the only issue, then this PR can be merged, @KrahJohlito ? |
I’m not actually sure tbh, as with my other pr I think it’s fine as is :-p .. @J013k am I correct that 2) isn’t a new issue brought on by this pull request? Other than that I don’t think he likes that the config is reloaded upon entering the menu, this is because the menu is in two places at once one using pergame & global and the other only global but it all uses the same code to avoid duplication.. I suppose some variables could possibly be duplicated as global but idk I really haven’t thought about it since I opened this.. I could possibly revisit it when I get back but that won’t be anytime soon, using laptop and having no ps2 to test is too much hassle.. personally I think it’s fine though. |
Now this PR has merge conflicts |
I'll rebase this myself later |
@KrahJohlito I have tested recent As for number 1, if something can be done in this matter it will be great. So to sum up: Best regards. |
Add Controller Settings to menu
Add Controller Settings to menu
Pull Request checklist
Note: these are not necessarily requirements
Pull Request description
Solves #401
Moved a couple pad specific settings to 'Controller Settings' and added a global option for pademu in there so people can pair their devices while using USB for games.. Seeing as pademu can be used in OPL GUI I have no issue having it here but I left per game also because I'm not sure if people disable it per game for games that don't work? I don't use pademu so idk..
Unlike other menus we need to reload the cfg upon entry since it can be changed in multiple locations.. so if changes are made, not saved and then re-enter the pademu menu the cfg will be reloaded and changes wiped..so make sure to save changes if you wanna keep em..