BDM: Make loading block device modules other than USB optional #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still like to see that any new GUI option is mentioned somewhere in some readme file :) |
AKuHAK
approved these changes
Jun 24, 2021
rickgaiser
approved these changes
Jun 25, 2021
|
Thank you @KrahJohlito , merging. |
AKuHAK
pushed a commit
that referenced
this pull request
Sep 30, 2021
BDM: Make loading block device modules other than USB optional
citronalco
pushed a commit
to citronalco/OPL-Daily-Builds
that referenced
this pull request
Sep 10, 2023
BDM: Make loading block device modules other than USB optional
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Note: these are not necessarily requirements
Pull Request description
This is just to make loading of additional block device modules optional, I tested and it works fine.
I did originally have an option for USB on/off also but it was more hassle than its worth as it appears one set of modules must be loaded otherwise I would just get BSOD when loading BDM modules..so the obvious choice is to have USB as the default block device and all others IEEE 1394, MX4SIO & UDP optional.
I don't see any point in adding language strings for names of things, devices etc since..they would always be the same so FireWire is hardcoded..as seen below.
