Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module makefiles synced with mainstream SDK #439

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Module makefiles synced with mainstream SDK #439

merged 1 commit into from
Jun 18, 2021

Conversation

AKuHAK
Copy link
Member

@AKuHAK AKuHAK commented Jun 16, 2021

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK
  • Requires update of the gsKit
  • Others (please specify below)

Pull Request description

@AKuHAK AKuHAK marked this pull request as draft June 16, 2021 18:39
@AKuHAK
Copy link
Member Author

AKuHAK commented Jun 16, 2021

Once ps2dev/ps2sdk#178 will be merged this can be merged as well. As for me, it is better to keep makefile rules in the mainstream sdk (as already done for ee).

@AKuHAK AKuHAK marked this pull request as ready for review June 18, 2021 12:24
@AKuHAK
Copy link
Member Author

AKuHAK commented Jun 18, 2021

This PR is ready for review.

Copy link
Member

@uyjulian uyjulian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@AKuHAK AKuHAK merged commit 58c268b into ps2homebrew:master Jun 18, 2021
@AKuHAK AKuHAK deleted the modules_sync branch June 18, 2021 13:09
AKuHAK added a commit that referenced this pull request Sep 30, 2021
Module makefiles synced with mainstream SDK
citronalco pushed a commit to citronalco/OPL-Daily-Builds that referenced this pull request Sep 10, 2023
Module makefiles synced with mainstream SDK
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants