Update gfx for BDM

[KrahJohlito]

Pull Request checklist

Note: these are not necessarily requirements

• I reformatted the code with clang-format
• I checked to make sure my submission worked
• I am the author of submission or have permission from the original author
• Requires update of the PS2SDK
• Requires update of the gsKit
• Others (please specify below)

Pull Request description

Just updating gfx for BDM.

In order to maintain theme compatibility I've named the BDM device icon as usb.png and all block devices handled by BDM with a _bd suffix. The idea is to change the const int IDs of both the device text and icon to simple functions to determine which string/icon to display depending on which device is connected and the standard BDM icon/text for manual init or when it is set to OFF.

Currently though I'm having difficulty obtaining the device name without hacks, perhaps when/if there are EE side functions for BDM this will be easier so for now not all icons are used.

Thanks to Berion for the updated gfx.

[rickgaiser]

Nice work on the icons, thanks!

[J013k]

What about line 35 (USB Games) in English template:
https://github.com/ps2homebrew/Open-PS2-Loader/blob/master/lng/lang_English.lng#L35
Does this line also should be changed into BDM Games?

I am asking because I want to update all the translations...

EDIT: I have noticed that there is a string BDM Games in line 303:
https://github.com/ps2homebrew/Open-PS2-Loader/blob/master/lng/lang_English.lng#L303.

So do we need string\line 35 or 303? Or one of this line can be "replaced", the other one deleted?

[rickgaiser]

Originally I re-used the string in line 35, but this has now been changed to a new string on line 303. I would prefer re-using the string on line 35 so we don't get too many dead items in the language files, but this requires a partial revert of 991644f. @KrahJohlito do you agree?

This should be renamed back to _STR_BDM_GAMES

Open-PS2-Loader/include/lang.h

Line 18 in 7758357

_STR_USB_GAMES,

And this should be removed:

Open-PS2-Loader/include/lang.h

Line 286 in 7758357

_STR_BDM_GAMES,

[KrahJohlito]

Sorry @rickgaiser I must have mentions off I only just saw this when @J013k messaged me about it today.

In the next couple days I plan to use both language strings as well as adding another for FireWire Games (although I’m not sure it’s even necessary to have a seperate string for each device since only the word “Games” would need to be translated I assume). I’ll make sure template and Lang.c are consistent, sorry for the confusion.