Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apps Menu #349

Merged
merged 1 commit into from
Jan 8, 2021
Merged

Add Apps Menu #349

merged 1 commit into from
Jan 8, 2021

Conversation

KrahJohlito
Copy link
Member

@KrahJohlito KrahJohlito commented Jan 7, 2021

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK
  • Requires update of the gsKit
  • Others (please specify below)

Pull Request description

This adds an Apps Menu so we can rename and delete APPS again, its very basic at the moment but more could be added in the future.

closes #347

Copy link
Member

@rickgaiser rickgaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but what do think about merging the names "Game Menu" and "Apps Menu" to "Options"?

Also I think it would be "App Menu" (without the 's'), as it's the menu of 1 app. Just like "Game Menu" is the menu of 1 game. But overall I think "Options" makes more sense for both. What do you think?

@KrahJohlito
Copy link
Member Author

KrahJohlito commented Jan 7, 2021

Ah yea good point, updated

Edit: sorry I realised the condition I was using became irrelevant after the last push so I just cleaned it up, I think its really done now.

@rickgaiser
Copy link
Member

It's ready to pull?

@TnA-Plastic
Copy link

TnA-Plastic commented Jan 8, 2021

I would have used "options" as well, BUT this might make people mix it up with the settings for OPL instead of the per-game/app-settings.

@KrahJohlito
Copy link
Member Author

Yea it’s ready, just did one final push to drop the ‘s’ from function names, definitions and variables.

@rickgaiser rickgaiser merged commit c3f9ab8 into ps2homebrew:master Jan 8, 2021
@KrahJohlito KrahJohlito deleted the apps-menu branch January 9, 2021 01:16
AKuHAK pushed a commit that referenced this pull request Sep 30, 2021
citronalco pushed a commit to citronalco/OPL-Daily-Builds that referenced this pull request Sep 10, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE]Renaming & Deleting Apps
3 participants