Always use "CFG" folder (no more "CFG-DEV") #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrahJohlito
approved these changes
Jan 5, 2021
AKuHAK
pushed a commit
that referenced
this pull request
Sep 30, 2021
Always use "CFG" folder (no more "CFG-DEV")
citronalco
pushed a commit
to citronalco/OPL-Daily-Builds
that referenced
this pull request
Sep 10, 2023
Always use "CFG" folder (no more "CFG-DEV")
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As also discussed in #343 .
For the past 5 years everyone has been using development builds. These builds differ from releases in the following:
I don't think there should be any difference between development builds and release builds for the name of the 'CFG' folder. Just like all the other folders don't have special 'DEV' versions. So this removes the option, and always uses the 'CFG' folder.
For the 'dev=1' parameter sent to http://sx.sytes.net/oplcl I could not find any reason. To test the difference I created 2 OPL builds, 1 with the parameter, and 1 without. Then had them download the configs for all games in my catalog. Then I used a compare tool to compare all configs: they are exactly the same. So I think this should be removed as well.
Test build can be downloaded here:
https://github.com/rickgaiser/Open-PS2-Loader/suites/1770659249/artifacts/33794362