Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate compilation and generation of release artifacts. #271

Merged
merged 3 commits into from
May 23, 2020

Conversation

fjtrujy
Copy link
Contributor

@fjtrujy fjtrujy commented May 20, 2020

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK
  • Requires update of the gsKit
  • Others (please specify below)

Pull Request description

This PR is doing basically 3 things:

  1. Use the new docker layers generated by the ps2dev team for assuring that the Open-PS2-Loader is compiling in all different compilation flavors
  2. Generate release artifacts that users can easily download it.
  3. Finally, it is showing in the readme the current CI status

@rickgaiser has been collaborating closely with me to achieve this.

Thanks

@rickgaiser
Copy link
Member

Awesome work @fjtrujy !

This way we can check every PR (also with downloadable ELF file), and every new build will have a downloadable ELF attached to it.

Should we also remove .travis.yml ?

@fjtrujy
Copy link
Contributor Author

fjtrujy commented May 20, 2020

Hello @rickgaiser,

I think that before removing TravisCI we probably need to implement the same things in GitHub Actions, so far I see that it contains the release of the documentation as well.

But probably it is better to do it in a separate PR.

What do you think?

@rickgaiser
Copy link
Member

Separate PR for .travis.yml is fine, then we're ready for merge.
@ElPatas1 can you merge this?

@fjtrujy
Copy link
Contributor Author

fjtrujy commented May 20, 2020

I forgot to mention,
The best benefit of using dockers is that we are saving a lot of time in the CI/CD.
Now everything is done ins LESS THAN 2 MINUTES!! when previously I'm pretty sure that it needed more than 20 minutes.

You can see the values in my fork.
https://github.com/fjtrujy/Open-PS2-Loader/actions/runs/110335708

Thanks

@ElPatas1
Copy link
Contributor

This is to make automatic compilations online or something like this?
I don't have to change something in my configuration when i compile myself the OPL?

Looking at one of the commits i see that the different functions to compile PADEMU, IGS,
DEBUG are included, but it is missing the "RTL" function, no?
make RTL=1

Best regards.

@fjtrujy
Copy link
Contributor Author

fjtrujy commented May 20, 2020

Hello @ElPatas1 ,
Yes it will automatically generate elf files without any additional change.

If there are additional compilation scenarios missing we can add them later, for now the most important thing is to have the CI/CD working, as we currently don't have anything.

Trust me, merge it, and you will see

@AKuHAK
Copy link
Member

AKuHAK commented May 21, 2020

@fjtrujy thank you for this amazing work!!!

@ElPatas1
Copy link
Contributor

@fjtrujy, i see, when you can add please the RTL compilation feature,
it is merged, thank you.

Best regards.

@ElPatas1 ElPatas1 merged commit a95959f into ps2homebrew:master May 23, 2020
AKuHAK pushed a commit that referenced this pull request Sep 30, 2021
Automate compilation and generation of release artifacts.
citronalco pushed a commit to citronalco/OPL-Daily-Builds that referenced this pull request Sep 10, 2023
Automate compilation and generation of release artifacts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants