-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes and add notifications feature #222
Conversation
* sfx: code clean up * lng: fix font not being rendered if loading translations at boot from a device other than MC, and if lang is changed by manually initalising a device * gui: add notifications
Please don't forget to also update the following template file: I believe the protocol is whenever updating the |
@Jay-Jay-OPL Thanks, will do it tomorrow. |
* sfx: code clean up * lng: fix font not being rendered if loading translations at boot from a device other than MC, and if lang is changed by manually initalising a device * gui: add notifications * gui: reduce notifications code
@ElPatas1 Commits added for English Template & more efficient notifications code. |
I've tried this test version yesterday. I can even get 3 notification at the same time when the device will be automatically started, Although I didn't notice notification when the device will be manually initialize. Anyway thanks for current progress. |
Hello, the new real strings or changed in lang.c for do changes in the custom Settings saved to %s Please confirm this. And if the notifications is supposed to work also when the devices Best regards. |
@ElPatas1 also %s loaded from %s The other changes were just for aesthetic reasons. Best regards. |
If it is merely a call to the new notification-function which is missing after manual initialization, I also hope for them to be added, but if it is more work I think it should be merged and a fix for the manual devices can be pushed later as well. ;) But it is great to have the new notification-feature as well as the fixes! Can't wait for it being merged with or without showing the manually started devices. Maybe it was left out intentionally for the manual devices?! |
) * sfx: code clean up * lng: fix font not being rendered if loading translations at boot from a device other than MC, and if lang is changed by manually initalising a device * gui: add notifications * gui: reduce notifications code * notifications: show upon manual device init, if thm or lang changed
Ok done, sorry forgot all about manual device init.. added now. |
Great! :) |
@J013k updated test build. |
True, but those are not related to the pull requests here and to the notification-feature, so I am all for a merge! |
@Tupakaveli, thank you i not saw it. Best regards. |
Small fixes and add notifications feature
Small fixes and add notifications feature
Pull Request checklist
Note: these are not necessarily requirements
Pull Request description
SFX code cleanup.
Fix font not being rendered for custom language when loaded from manually started device.
Add notifications feature - disabled by default.
Standardise English language strings - use title case for menu/settings items, use sentence case for messages/hints.
Updated test build: https://www.sendspace.com/file/rsjzc7