-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lots of fixes and small improvements #217
Conversation
…alignment correction is performed." This reverts commit cd100a2.
Due to alignment the buffer can be overrun by the alignment size (64 bytes).
Some iop modules would always be rebuilt (like cdvdman* and mcemu*). Slowing down compilation times.
Thanks for lots of improvements. |
The theme was activated before it was fully loaded. This fix activates the theme at the end of the loading.
Fix for #216 added. |
Those interested can find an automated build of OPL including this PR here: |
I've only tried USB device. When starting device will set - Auto. Problem starts with manual initializing. When I selected both lng & thm, save settings, reboot, launch OPL, start device, Translation was taken from this topic: So currently loading themes (thm) is working no matter how device will be started, Here is how lng support evolved recently: Unfortunately currently I don't have time to test at least one of these games. |
@J013k Here’s the fix |
I've tried activating custom languages from usb, but I cannot get it to work correctly, not even the english one. In the debug output I see that only 7 or 8 language texts are loaded. Then in the main menu some texts (probably 7 or 8) are gone. I've triend converting the language files with dos2unix/unix2dos, but that doesn't help. I think it's better if @KrahJohlito fixes the language issues separately. Please merge this PR. |
Commit merged. Best regards. |
Lots of fixes and small improvements
Lots of fixes and small improvements
Fix issue #211 tested with:
Add Makefile targets to simplify testing:
Replace all instances of printf with LOG. The LOG macro will only add printf statements for debugging versions. So it doesn't waste space for release versions.
Fix sound module trying to "free" builtin sounds. Only "malloc"ed sounds should be freed.
Merge 3 almost identical "Rules.make" files. And also prevent rebuilding files that have not been changed. This caused "make opl.elf" to always rebuild some modules. Compilation is a lot faster now on my slow laptop ;-)
Fix buffer overrun in ioprp_image. We forgot t account for the eesync module size.