Updates and fixes #208
Updates and fixes #208
Conversation
|
I haven't seen the icon yet, but I certainly hope for the fade-transition finally being merged into the official repo! |
|
More commits sounds good. Hopefully OPL will finally be released as 0.9.4 once all is done. The fade-transition 'perfectens' the HD-Support and that alone (HD-Stuff) is worth a step from 0.9.3 to 0.9.4 and there where hundreds of other additions and changes, since the last release. I am dl-ing the new icons and put it on the MC, for the time being (so I can see a new 3D-Icon). |
|
THX for the last fix. SFX-Support per theme is a good reason for releasing OPL as 0.9.4 as well! |
|
One little bug which @Jolek found. The code which checks for an OPL-Folder (and/or writes the MC-Icon) overwrites the OPL-Icon at every boot. It is essentially just missing a switch-case or exception, when it should not write the new icons (i.e. if they or other icons are already present). |
|
Thanks, he already reported it. |
|
Alright! I just mentioned it, in case he didn't! ;) |
|
Hello, is needed to merge this commit? is well tested? or i still wait? Best regards. |
|
It is working well... (except for the icon-replacement-bug) The only thing I can think of, which could be merged as well is BGM-Support! :P Anyway... It is up to @Tupakaveli and @KrahJohlito, if this is gonna be merged. The Fade-transition technically could be merged without their consent, because it is Maximus32's/ @rickgaiser 's code and he said we can do with it, whatever we want... |
|
Please wait until the memory card icon writing commit has been reverted. It solved one issue but caused another which we have been unable to find a fix for as of yet. Everything else has been tested. Best regards. |
|
This can be merged now if you wish. We're going to try and fix a couple of other things so I will open another PR later if required. If we can find a fix for the memory card icon writing bug it will be added. Best regards. |
|
Cool! :) |
|
When is 0.9.4 releasing ? |
|
Soon. As Tupakaveli said above, other fixes are in order. Especially the MC icon writing bug. I'd rather see that bug fixed before releasing 0.9.4 if possible ... |
|
Awesome !! |
Updates and fixes
Pull Request checklist
Note: these are not necessarily requirements
Pull Request description
Memory Card icon update.
Discussion: https://www.psx-place.com/threads/open-ps2-loader-v0-9-3.13415/page-40#post-193454
To test: https://www.sendspace.com/file/emn0nc
Replace slide transition with Maximus32's fade transition.
This transition animation looks a lot better and it also fixes a memory issue for HiRes themes that use the info page.
Thanks to @rickgaiser for his code
Video for reference: https://www.youtube.com/watch?v=OKE6IZoopj4&t=5s
Fix transition sound effect.
Replaced default transition sound effect as it doesn't fit with the fade transition.
Free sound effect taken from: https://sellfy.com/p/gPCb/#
Latest test build: https://www.sendspace.com/file/tqetk2