Add a way to print a list of sprite #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjtrujy
commented
Dec 10, 2024
|
|
||
| typedef union { | ||
| u128 stq; | ||
| struct { | ||
| gs_stq_t st; | ||
| u64 tag; | ||
| }; | ||
| } __attribute__((packed, aligned(8))) gs_stq; |
There was a problem hiding this comment.
It had wrong alignment it should be 16 instead, but let the compiler to take it based on u128
fjtrujy
commented
Dec 10, 2024
|
|
||
| typedef union { | ||
| u128 uv; | ||
| struct { | ||
| u64 coord; | ||
| u64 tag; | ||
| }; | ||
| } __attribute__((packed,aligned(8))) gs_uv; | ||
| } __attribute__((packed)) gs_uv; |
There was a problem hiding this comment.
It had wrong alignment it should be 16 instead, but let the compiler to take it based on u128
fjtrujy
commented
Dec 10, 2024
|
|
||
| typedef union { | ||
| u128 rgbaq; | ||
| struct { | ||
| gs_rgbaq_t color; | ||
| u64 tag; | ||
| }; | ||
| } __attribute__((packed,aligned(8))) gs_rgbaq; | ||
| } __attribute__((packed)) gs_rgbaq; |
There was a problem hiding this comment.
It had wrong alignment it should be 16 instead, but let the compiler to take it based on u128
fjtrujy
force-pushed
the
sprite_list
branch
2 times, most recently
from
d62f47a to
9dbd3b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does:
gsKit_prim_list_sprite_gouraud_3dfor allowing to draw a list of spritesgsKit_clearfor usinggsKit_prim_list_sprite_gouraud_3dbetter.Cheers