feat: cell proof computation related proto and generated go files #15003
+545
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x00101010
requested review from
potuz,
terencechain and
rkapka
and removed request for
a team
terencechain
reviewed
Mar 3, 2025
Comment on lines
247
to
267
| message BlobsBundleV2 { | ||
| // The KZG commitments of the blobs. | ||
| repeated bytes kzg_commitments = 1 [ | ||
| (ethereum.eth.ext.ssz_size) = "?,48", | ||
| (ethereum.eth.ext.ssz_max) = "max_blob_commitments.size" | ||
| ]; | ||
|
|
||
| // The cell_proofs for all blobs | ||
| // TODO: update ssz_max when it's defined in the spec | ||
| repeated bytes cell_proofs = 2 [ | ||
| (ethereum.eth.ext.ssz_size) = "?,48", | ||
| (ethereum.eth.ext.ssz_max) = "max_blob_commitments.size" | ||
| ]; | ||
|
|
||
| // The blobs itself. | ||
| repeated bytes blobs = 3 [ | ||
| (ethereum.eth.ext.ssz_size) = "?,blob.size", | ||
| (ethereum.eth.ext.ssz_max) = "max_blob_commitments.size" | ||
| ]; | ||
| } | ||
|
|
There was a problem hiding this comment.
In general, it’s best to define new protobuf messages in their own files, such as execution_engine_eip7594.proto or something similar. Keeping everything in a single file increases the risk of conflicts, especially with multiple feature branches in development
0x00101010
force-pushed
the
cell-proof-computation-proto
branch
from
d95cb37 to
d6bbe00
Compare
terencechain
reviewed
Mar 4, 2025
There was a problem hiding this comment.
Lgtm. Thanks for considering my feedback. Will let @nalepae approve and merge this one
…le does not exists. Rerun ` hack/update-go-pbs.sh` and `hack/update-go-ssz.sh `.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
commit cell proof computation related proto and generated go files, see ethereum/execution-apis#630
Which issues(s) does this PR fix?
Fixes #14129
Other notes for review
Acknowledgements