Builder ssz #14976
Builder ssz #14976
Conversation
james-prysm
added
Builder
| opt := func(r *http.Request) { | ||
| r.Header.Set(api.VersionHeader, version.String(sb.Version())) | ||
| r.Header.Set("Content-Type", api.OctetStreamMediaType) | ||
| r.Header.Set("Accept", api.OctetStreamMediaType) |
There was a problem hiding this comment.
should the Accept also have json to properly process error message?
| // EnableBuilderSSZ enables Builder APIs to send and receive in SSZ format | ||
| EnableBuilderSSZ = &cli.BoolFlag{ | ||
| Name: "enable-builder-ssz", | ||
| Aliases: []string{"builder-ssz"}, |
There was a problem hiding this comment.
Why defining an alias here?
There was a problem hiding this comment.
just as a shorter name, some other clients have it as this I think.
| errMalformedHostname = errors.New("hostname must include port, separated by one colon, like example.com:3500") | ||
| errMalformedRequest = errors.New("required request data are missing") | ||
| errNotBlinded = errors.New("submitted block is not blinded") | ||
| blockToPayloadMapping = map[int]int{ |
There was a problem hiding this comment.
Is it possible to use a function instead like:
if blockVersion >= version.Deneb {
return version.Deneb
}
return blockVersionRationale: It will lighten the burden for the boilerplate creation in future forks.
| return nil, errors.Wrap(err, fmt.Sprintf("unsupported header version %s", versionHeader)) | ||
| } | ||
|
|
||
| switch { |
There was a problem hiding this comment.
Isn't it more idiomatic to have multiple ifs starting with if ver >= version.Electra then if ver == version.Deneb, if ver == version.Capella... ?
| forkVersion int, | ||
| ) (interfaces.ExecutionData, *v1.BlobsBundle, error) { | ||
| switch { | ||
| case forkVersion >= version.Deneb: |
There was a problem hiding this comment.
Same question here for if vs switch.
There was a problem hiding this comment.
I'm fine with going with if, i'll change it
Co-authored-by: Manu NALEPA <[email protected]>
Co-authored-by: Manu NALEPA <[email protected]>
What type of PR is this?
Feature
What does this PR do? Why is it needed?
implements ssz mode for using a builder setup, the following endpoints will request and receive responses in ssz format when the
--enable-builder-ssz=trueflag is passed to the beacon node/eth/v1/builder/header/{{.Slot}}/{{.ParentHash}}/{{.Pubkey}}/eth/v1/builder/blinded_blocks/eth/v1/builder/validatorsnote: this pr does not update builder E2E to support ssz, this is another todo item for proper testing
Which issues(s) does this PR fix?
Fixes # ethereum/builder-specs#104, ethereum/builder-specs#110
Other notes for review
Acknowledgements