Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalized validator index cache saving #14146

Merged
merged 6 commits into from
Jun 26, 2024

Conversation

james-prysm
Copy link
Contributor

@james-prysm james-prysm commented Jun 25, 2024

What type of PR is this?

Feature

What does this PR do? Why is it needed?

part of #13944 breakup

It may need to be removed or updated as part of ethereum/consensus-specs#3689 ethereum/consensus-specs#3818

this PR adds saving to the validator index cache but is feature-gated,
we will remove the feature gate when appropriate

Which issues(s) does this PR fix?

Fixes #

Other notes for review

@james-prysm james-prysm requested a review from a team as a code owner June 25, 2024 20:23
@james-prysm james-prysm added the Electra electra hardfork label Jun 25, 2024
@james-prysm james-prysm requested review from terencechain and removed request for nisdas June 25, 2024 20:51
terencechain
terencechain previously approved these changes Jun 26, 2024
Copy link
Member

@prestonvanloon prestonvanloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion

beacon-chain/state/state-native/setters_misc.go Outdated Show resolved Hide resolved
Co-authored-by: Preston Van Loon <[email protected]>
@james-prysm james-prysm added this pull request to the merge queue Jun 26, 2024
Merged via the queue into develop with commit f230a6a Jun 26, 2024
17 checks passed
@james-prysm james-prysm deleted the finalized-validator-cache-saving branch June 26, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Electra electra hardfork
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants