Switch eth/v1 and v1alpha1 to protoc-gen-go-cast#210
Conversation
0xKiwi
requested review from
a team,
nisdas,
prestonvanloon,
rauljordan and
terencechain
as code owners
This reverts commit 617ed8d.
| @@ -0,0 +1,3 @@ | |||
| // +build ignore | |||
|
|
|||
| package ignore | |||
There was a problem hiding this comment.
Why do we need this? I forget...
There was a problem hiding this comment.
Part of the compilation output. I can try removing it in a later point but not in scope for this repo.
| # gRPC Gateway | ||
|
|
||
| This package is contains generated files for applications that wish to use eth/v1alpha as a | ||
| [gRPC gateway](https://github.com/grpc-ecosystem/grpc-gateway). No newline at end of file |
There was a problem hiding this comment.
Do you want to just delete this file? seems weird to clear out all of the contents.
There was a problem hiding this comment.
Replaced with a README in v1/ and v1alpha1/
This reverts commit b798ec6.
nisdas
left a comment
nisdas
left a comment
There was a problem hiding this comment.
Please revert all the permission changes, a lot of files have been changed from 0755 to 0644
| go_rules_dependencies() | ||
|
|
||
| go_register_toolchains() | ||
| go_register_toolchains(version="1.15.5") |
There was a problem hiding this comment.
lets put this in parity with out current used go version in prysm 1.16.4 . Will also need rules_go to again be updated above. Same for gazelle
|
@nisdas the permissions are supposed to be 0644. |
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
5 participants
This PR changes eth/v1 and eth/v1alpha1 to use protoc-gen-go-cast entirely.
Also unites _gateway into the normal folders.
Please focus your review on the
.protofiles, the rest is mainly generated. The only changes should be extension tags.Dependencies are rather messy but would rather clean them up at a later point.
This in particular changes us from relying on the compilers at: "github.com/gogo/protobuf/proto"
To start using the native protobuf v2 compilers hosted at: "google.golang.org/protobuf/proto" (not github.com, thats v1)
More context on the changes here:
https://hackmd.io/wO5rzfVWS3GrS-L7FNXKGg