Merge pull request #28 from prplecake/update-logging

prplecake · Mar 29, 2023 · e571f4f · e571f4f
2 parents 94f0f42 + 25a8c4c
commit e571f4f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/BookmarkSync.Core/BookmarkSync.Core.csproj b/BookmarkSync.Core/BookmarkSync.Core.csproj
@@ -16,6 +16,7 @@
       <PackageReference Include="Microsoft.Extensions.Configuration" Version="7.0.0" />
       <PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="7.0.4" />
       <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
+      <PackageReference Include="Serilog" Version="2.12.0" />
       <PackageReference Include="System.Configuration.ConfigurationManager" Version="7.0.0" />
     </ItemGroup>
 

diff --git a/BookmarkSync.Core/Configuration/ConfigManager.cs b/BookmarkSync.Core/Configuration/ConfigManager.cs
@@ -5,6 +5,7 @@
 using BookmarkSync.Core.Entities.Config;
 using CiT.Common.Exceptions;
 using Microsoft.Extensions.Configuration;
+using Serilog;
 
 namespace BookmarkSync.Core.Configuration;
 
@@ -17,15 +18,17 @@ public interface IConfigManager
 }
 public class ConfigManager : IConfigManager
 {
+    private static readonly ILogger _logger = Log.ForContext<ConfigManager>();
     public ConfigManager(
         IConfiguration configuration)
     {
         Configuration = configuration;
-        App = Configuration.GetSection("App").Get<App>() ?? throw new NullReferenceException();
+        App = Configuration.GetSection("App").Get<App>() ?? throw new InvalidOperationException();
         Instances = Configuration.GetSection("Instances").Get<List<Instance>>();
 
         if (!App.IsValid())
         {
+            _logger.Error("App configuration is invalid");
             throw new InvalidConfigurationException();
         }
     }
@@ -34,6 +37,7 @@ public ConfigManager(
     public App App { get; set; }
     public string GetConfigValue(string key)
     {
+        _logger.Debug("Running {Method} for key: {Key}", "GetConfigValue", key);
         string? value = Configuration[key];
         if (string.IsNullOrWhiteSpace(value))
         {

diff --git a/BookmarkSync.Infrastructure/Services/Bookmarking/BookmarkSyncService.cs b/BookmarkSync.Infrastructure/Services/Bookmarking/BookmarkSyncService.cs
@@ -30,7 +30,7 @@ public async Task StartAsync(CancellationToken stoppingToken)
     {
         if (_instances == null || _instances.Count == 0)
         {
-            _logger.Information("No instances configured");
+            _logger.Warning("No instances configured");
             return;
         }
         foreach (var instance in _instances)
@@ -72,6 +72,7 @@ public async Task StartAsync(CancellationToken stoppingToken)
 
                 if (instance.DeleteBookmarks && result.IsSuccessStatusCode)
                 {
+                    _logger.Information("Deleting bookmark");
                     await client.DeleteBookmark(bookmark);
                 }
             }