Merge pull request #88 from prplecake/dev/tweaks

prplecake · Jul 6, 2023 · 81bd1ad · 81bd1ad
2 parents 538c09d + cb69809
commit 81bd1ad
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/BookmarkSync.Core/Configuration/ConfigManager.cs b/src/BookmarkSync.Core/Configuration/ConfigManager.cs
@@ -27,9 +27,9 @@ public ConfigManager(
             throw new InvalidConfigurationException();
         }
     }
-    public IConfiguration Configuration { get; set; }
-    public List<Instance>? Instances { get; set; }
-    public App App { get; set; }
+    private IConfiguration Configuration { get; }
+    public List<Instance>? Instances { get; }
+    public App App { get; }
     public string GetConfigValue(string key)
     {
         _logger.Debug("Running {Method} for key: {Key}", "GetConfigValue", key);
@@ -44,5 +44,6 @@ public string GetConfigValue(string key)
     public void SaveToFile()
     {
         Console.WriteLine(Directory.GetCurrentDirectory());
+        throw new NotImplementedException();
     }
 }
diff --git a/src/BookmarkSync.Core/Meta.cs b/src/BookmarkSync.Core/Meta.cs
@@ -4,7 +4,7 @@ namespace BookmarkSync.Core;
 
 public static class Meta
 {
-    public const string
+    private const string
         Name = "mastodon-bookmark-sync",
         Version = "2.0";
     public static readonly ProductInfoHeaderValue UserAgent = new(Name, Version);

diff --git a/tests/BookmarkSync.Core.Tests/Configuration/ConfigManagerTests.cs b/tests/BookmarkSync.Core.Tests/Configuration/ConfigManagerTests.cs
@@ -31,8 +31,7 @@ public void Init()
     public void ConfigManager_HasProperties()
     {
         // Assert
-        Assert.AreEqual(3, _configManager?.PropertyCount());
-        Assert.IsTrue(_configManager?.HasProperty("Configuration"));
+        Assert.AreEqual(2, _configManager?.PropertyCount());
         Assert.IsTrue(_configManager?.HasProperty("Instances"));
         Assert.IsTrue(_configManager?.HasProperty("App"));