Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a BenchmarkDotNet job that can run benchmarks against the published NuGet package (instead of the local source projects) by switching references via a custom build configuration.
Changes:
- Simplifies benchmark startup to always use
BenchmarkConfigdirectly. - Extends
BenchmarkConfigto include a new “NuGet package” job using a custom build configuration. - Updates the benchmark
.csprojto switch betweenProjectReference(local source) andPackageReference(published NuGet) based on configuration.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| sandbox/Benchmark/Program.cs | Stops calling the removed AddTargetFramework() and uses BenchmarkConfig directly. |
| sandbox/Benchmark/Config/BenchmarkConfig.cs | Moves framework job setup into the constructor and adds a NuGet-comparison job using WithCustomBuildConfiguration(...). |
| sandbox/Benchmark/Benchmark.csproj | Adds conditional package vs project references depending on $(Configuration) (NuGet vs local source). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merged
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add a new benchmark job with custom build configuration "NuGetCsToml" to enable performance comparison between the current source and the published NuGet package version.