Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR officially supports the TOML v1.1.0 specification by introducing predefined TomlSpec configurations (Version100 and Version110) and reorganizing features to distinguish between official v1.1.0 features and unofficial extensions. The key change is moving AllowUnicodeInBareKeys from v1.1.0 features to unofficial extensions, aligning with the actual TOML v1.1.0 specification.
- Introduces static
TomlSpec.Version100andTomlSpec.Version110for convenient specification selection - Reorganizes TOML v1.1.0 features into official and unofficial categories
- Updates documentation to clearly differentiate official v1.1.0 features from unofficial extensions
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/CsToml/CsTomlSerializerOptions.cs | Adds Version100 and Version110 static properties to TomlSpec, reorganizes features into official v1.1.0 and unofficial sections with XML documentation, changes default spec to Version100 |
| tests/CsToml.Tests/Options.cs | Updates TomlSpecVersion110 to use TomlSpec.Version110, adds new AllowUnicodeInBareKeys option for testing the unofficial extension |
| tests/CsToml.Tests/DefaultTest.cs | Changes Unicode bare keys test to use AllowUnicodeInBareKeys option instead of TomlSpecVersion110 |
| tests/CsToml.Extensions.Configuration.Tests/Options.cs | Simplifies TomlSpecVersion110 to use the new TomlSpec.Version110 static property |
| README.md | Updates documentation to reflect official v1.1.0 support, reorganizes feature descriptions into separate sections for v1.1.0 and unofficial extensions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Owner
Author
|
I plan to update TOML test-case as well, but since we found bugs during the process, so I'll fixed. |
…-line inline tables. Update toml-test case.
Merged
This was referenced Jan 12, 2026
This was referenced Jan 19, 2026
This was referenced Jan 27, 2026
This was referenced Feb 3, 2026
This was referenced Feb 11, 2026
This was referenced Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes TOML v1.1.0's features to official optional features.
#84