Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds .NET 10 target framework support across the CsToml codebase, updating project files, build configurations, benchmark tooling, and CI/CD workflows to prepare for .NET 10 compatibility. The changes also upgrade the C# language version from 13.0 to 14.0 and add a new NuGet pack-and-push workflow.
Key changes:
- Added
net10.0to target frameworks in source projects, test projects, and sandbox applications - Updated C# LangVersion from 13.0 to 14.0 in
src/Directory.Build.props - Modified benchmark configuration to use .NET 10 as the default benchmark target, with .NET 8 and 9 available via
AddTargetFramework() - Updated GitHub Actions workflows to include .NET 10.0.x in the SDK installation matrix
- Added new
nuget-pack-push.ymlworkflow for automated package publishing
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/CsToml.Tests/CsToml.Tests.csproj | Added net10.0 to TargetFrameworks |
| tests/CsToml.Generator.Tests/CsToml.Generator.Tests.csproj | Added net10.0 to TargetFrameworks |
| tests/CsToml.Extensions.Configuration.Tests/CsToml.Extensions.Configuration.Tests.csproj | Added net10.0 to TargetFrameworks |
| src/Directory.Build.props | Added net10.0 to TargetFrameworks and updated LangVersion to 14.0 |
| sandbox/ConsoleApp/ConsoleApp.csproj | Changed TargetFramework from net9.0 to net10.0 |
| sandbox/Benchmark/Program.cs | Switched benchmark config to use AddTargetFramework() for multi-framework benchmarking |
| sandbox/Benchmark/Config/BenchmarkConfig.cs | Changed default benchmark target from .NET 9.0 to .NET 10.0, added .NET 9.0 to AddTargetFramework() |
| sandbox/Benchmark/Benchmark.csproj | Added net10.0 to TargetFrameworks |
| CsToml.slnx | Added additional configuration files to solution |
| .github/workflows/nuget-pack-push.yml | New workflow for packing and publishing NuGet packages on version tags, includes .NET 10.0.x setup |
| .github/workflows/build.yml | Updated to use custom setup-dotnet action and added 10.0.x to SDK versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.