Add CsTomlFileSerializer.Deserialize/DeserializeAsync/Serialize/SerializeAsync overload accepting TomlFileExtensionPolicy#103
Merged
Merged
Conversation
…lizeAsync overload accepting TomlFileExtensionPolicy
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #102 by adding an opt-in mechanism to relax the .toml file-extension requirement in CsTomlFileSerializer through new overloads that accept a TomlFileExtensionPolicy.
Changes:
- Added
TomlFileExtensionPolicyenum (Strict/Relaxed) inCsToml.Extensions. - Added
Deserialize/DeserializeAsync/Serialize/SerializeAsyncoverloads that acceptTomlFileExtensionPolicy, with the existing overloads forwarding toStrict. - Added test coverage validating strict vs relaxed behavior across sync/async and serialize/deserialize paths.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| tests/CsToml.Tests/CsTomlFileSerializerExtensionPolicyTest.cs | Adds unit tests covering strict vs relaxed extension behavior across sync/async APIs. |
| src/CsToml.Extensions/TomlFileExtensionPolicy.cs | Introduces the TomlFileExtensionPolicy enum used by new overloads. |
| src/CsToml.Extensions/CsTomlFileSerializer.cs | Adds new overloads and centralizes extension validation logic via ValidateExtension. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merged
This was referenced May 13, 2026
This was referenced May 25, 2026
This was referenced Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#102
This PR add
CsTomlFileSerializer.Deserialize/DeserializeAsync/Serialize/SerializeAsyncoverload acceptingTomlFileExtensionPolicy.