-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @ReactModule
annotation
#94
Conversation
Add `@ReactModule` annotation, this will eventually be used by TurboModules annotation processor.
Hi @janicduplessis, What do you think? 🤔 |
@jdnichollsc Hmm why do we need to revert this? Should not be related to this PR. |
So is |
@jdnichollsc Yes it is included in react native already, there is no need to add dependencies. |
@janicduplessis thanks for your help mate, Do you know any link to see the documentation of this? 👍 |
There is not much documentation yet except react-native-community/discussions-and-proposals#40. Basically the annotation allows generating some info about the native module (mostly the name) that can be used by |
Also some info in this twitter thread https://twitter.com/janicduplessis/status/1157172268495179776 |
Hey mate, thanks for your help! In order to merge this PR, how can we avoid an issue like this? react-native-async-storage/async-storage#153 |
Hmm I think this might just happen as a result of a weird issue when upgrading. It is mentionned in the issue that it does not happen on a new project. |
Thanks for your help! 👍 |
Add `@ReactModule` annotation
Add
@ReactModule
annotation, this will eventually be used by TurboModules annotation processor.