Fix AppStateActiveOnce event listener #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@logangouget |
|
Just found that it happens only when redirectUrl parameter is undefined and browser is closed directly (in a logout scenario for example) |
|
@logangouget thanks for your help! can you revert changes from yarn.lock please? |
|
Thanks for your help! |
|
@jdnichollsc Did you mean for the |
|
No problem, I merged that change, I'm fixing some issues before to publish a new version, hope to finish that today |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, browser is closed before handling an AppState change, event is never triggered