-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory impact of span annotations should be improved: refactor data model #41
Comments
Major refactoring in both foliadocserve and flat is needed to come to a better model, this is becoming more of a necessity for issue #3, subissue e and f. |
This is a brainstorm comment for a better data model (subject to be edited heavily): CURRENT model:
Span annotations are duplicated per target word, NEW proposalAll structure elements will be first-level citizens under
Correction HandlingCorrections are stored as part of annotations:
Annotations or structural elements that are part of a correction have their |
…editor.js later + removed old loadannotations()
Things to verify after refactoring is complete (list subject to further editing):
|
…e that was retrieved in the latest update round #41
…e been implicit before but got lost in refactoring #41
…... structural corrections broken still
Structural corrections are broken |
"Show text prior to corrections" is broken |
…Using this for visualisation of structural corrections as well. (#41)
Structural corrections display again. |
|
Refactoring complete, but string handling still broken, continuing in issue #92 |
Span annotations are duplicated per word, causes some unnecessary overhead. Ideally, some type of references should be used instead.
The text was updated successfully, but these errors were encountered: