Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor/viewer dialog: newlines and whitespaces in text (FoLiA v2.5) #176

Closed
proycon opened this issue Jul 7, 2021 · 1 comment
Closed

Comments

@proycon
Copy link
Owner

proycon commented Jul 7, 2021

The editor dialog currently present a single-line input box, newlines are simply stripped. This is fine for editing tokenised text consisting of words as they are by definition single-line, but is an issue when editing untokenised text such as paragraphs. As we strip newlines, sentences get glued together. The editor dialog does correctly show the spacing.

  1. Currently the editor dialog can not deal with text-markup (of which newlines are a special instance). Full editing of text-markup support it complex and out of scope, but we can envision at least a fix for newline situation, presenting a <textarea> rather than an <input> for structural elements above the word level.

  2. The second issue is whitespace handling, the editor dialog actually shows this correctly, but the viewer dialog does not (nor does it show explicit newlines), we should base ourselves on the htmltext attribute rather than the text attribute for the viewer dialog.

This is related to proycon/foliadocserve#16 and the whitespace changes in FoLiA v2.5 in general.

@proycon proycon self-assigned this Jul 7, 2021
proycon added a commit that referenced this issue Jul 8, 2021
proycon added a commit that referenced this issue Jul 8, 2021
… text-markup is not supported (yet), this way it is squashed to a proper representation without markup #176
@proycon
Copy link
Owner Author

proycon commented Jul 8, 2021

Rather then extend to editor to support newlines, for now it simply renders newlines as spaces. This is consistent with the fact that editing text-markup is not supported and provides a fairly simple solution.

@proycon proycon added the ready label Jul 8, 2021
@proycon proycon closed this as completed Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant