Add call_foreign function#84
Add call_foreign function#84Gsantomaggio wants to merge 34 commits intoproxy-wasm:masterfrom Gsantomaggio:add_foreign
Conversation
|
I also need this feature @PiotrSikora could you please review this PR? |
|
This is blocked on #64, since there were no foreign functions in ABI v0.1.0, which Rust SDK implements. It should be merged over the next few days, and then this can be revived. (Sorry, I was sure I mentioned this before, but I don't see my comment.) |
|
Seems this can be considered now? Thanks for your work @PiotrSikora |
|
Hi @PiotrSikora |
|
Hi @Gsantomaggio! Sorry for the delay. It looks fine, but I wanted to run some tests and use it with existing foreign functions before merging it. Unfortunately, I'm still wrapped in restarting work on C++ Host (which has a much bigger lead-time) and fixing some recent regressions, and I didn't have time to get back to Rust SDK yet. Hopefully, I'll be able to do that next week. |
PiotrSikora
left a comment
There was a problem hiding this comment.
A few suggestions (nits + NotFound), but it looks good otherwise.
Thanks and again sorry for the delay!
Signed-off-by: Gabriele Santomaggio <g.santomaggio@gmail.com> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Co-authored-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Co-authored-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Co-authored-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Co-authored-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Co-authored-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
While there, add support for generating BUILD files with Bazel using @cargo_raze//:raze. Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Rei Shimizu <Shikugawa@gmail.com>
Signed-off-by: Shikugawa <Shikugawa@gmail.com>
While there, unify style and unwrap errors in gRPC traits. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Partially addresses #25. Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Found by clippy's needless_borrow check. Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Yaroslav Skopets <yaroslav@tetrate.io> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Fixes issues with addlicense requiring Go v1.16+. Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Martijn Swaagman <martijn@swaagman.online> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Martijn Swaagman <martijn@swaagman.online> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Martijn Swaagman <martijn@swaagman.online> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Martijn Swaagman <martijn@swaagman.online> Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
|
That's interesting, I followed the DCO instruction. but something went wrong. |
Signed-off-by: Gabriele Santomaggio g.santomaggio@gmail.com
Tested using:
result: