-
Notifications
You must be signed in to change notification settings - Fork 120
Make wee-alloc an optional feature. #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6f72876
allow building on non-wasm archs
yuval-k 0441a6d
format fix
yuval-k 61a5295
wee alloc as feature
yuval-k a9dd4b0
fix name
yuval-k 7f330a9
pr comments
yuval-k 1a1ac31
Merge remote-tracking branch 'origin/master' into allow-non-wasm-build
yuval-k e312307
regen raze
yuval-k 826a9f8
skip wee_alloc
yuval-k 8854512
only export malloc on wasm
yuval-k 322c173
fmt
yuval-k 7ffae68
Merge remote-tracking branch 'origin/master' into allow-non-wasm-build
yuval-k 0e02e12
no need to guard allocator now that there is no malloc collision
yuval-k dd21cd6
Add CI targets
yuval-k 0ac354f
pr comment
yuval-k File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,6 +16,7 @@ pub mod hostcalls; | |
| pub mod traits; | ||
| pub mod types; | ||
|
|
||
| #[cfg(feature = "wee-alloc")] | ||
| mod allocator; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You need to move this to |
||
| mod dispatcher; | ||
| mod logger; | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move
[features]before[dependencies]?