Fix returning value for empty header and make possible to differentiate between missing header and empty header #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
The method get_http_request_headers_bytes return empty vec for empty header value but get_http_request_header_bytes returns None for empty header value. this commit intends to fix this inconsistency. Signed-off-by: prembhaskal <[email protected]>
prembhaskal
force-pushed
the
fix-missing-vs-empty-header-value
branch
from
079fa02 to
e74213e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
get_http_request_headers_bytesreturn empty vector for empty header value butget_http_request_header_bytesreturns None for empty header value.This commit intends to fix this inconsistency.
With this, it will be possible to differentiate between two cases, a missing header and a header with empty value.