Skip to content

Update dependencies and resolve workflow failures#129

Closed
Swaagie wants to merge 10 commits intoproxy-wasm:masterfrom
Swaagie:master
Closed

Update dependencies and resolve workflow failures#129
Swaagie wants to merge 10 commits intoproxy-wasm:masterfrom
Swaagie:master

Conversation

@Swaagie
Copy link
Copy Markdown
Contributor

@Swaagie Swaagie commented Jan 26, 2022

Thought this might be a meaningful first contribution, updated dependencies and opted out of using the chrono crate for the hello_world example. I have no experience with bazel/raze before (up until now) so if I'm making crazy changes please let me know.

  • Updated cargo-raze to 0.14.1 (and adjusted build configs)
  • Updated to use rust edition 2021 as cargo metadata depended on latest without having to use nightly.
  • Removed chrono crate in favor of time crate to avoid having to wait for a resolution for the sec vun
  • Updated rust_rules to b3ddf6f096887b757ab1a661662a95d6b2699fa7
  • Fixed clippy suggested safe read of potentially unallocated memory with MaybeUninit
  • Regenerated lockfiles

Happy to change and update the PR where needed.

@Swaagie Swaagie requested a review from PiotrSikora as a code owner January 26, 2022 11:05
Signed-off-by: Martijn Swaagman <martijn@swaagman.online>
Signed-off-by: Martijn Swaagman <martijn@swaagman.online>
Signed-off-by: Martijn Swaagman <martijn@swaagman.online>
Signed-off-by: Martijn Swaagman <martijn@swaagman.online>
Signed-off-by: Martijn Swaagman <martijn@swaagman.online>
Signed-off-by: Martijn Swaagman <martijn@swaagman.online>
Signed-off-by: Martijn Swaagman <martijn@swaagman.online>
Signed-off-by: Martijn Swaagman <martijn@swaagman.online>
Signed-off-by: Martijn Swaagman <martijn@swaagman.online>
Signed-off-by: Martijn Swaagman <martijn@swaagman.online>
@PiotrSikora
Copy link
Copy Markdown
Member

Thanks, this looks fine, but could you please split this into multiple self-contained PRs?

@Swaagie
Copy link
Copy Markdown
Contributor Author

Swaagie commented Jan 26, 2022

Certainly, let the cherry picking commence 😄

@Swaagie
Copy link
Copy Markdown
Contributor Author

Swaagie commented Jan 26, 2022

Closing this in favor of smaller isolated PRs as requested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants