wavm: emit stack trace when an exception happens#84
Merged
PiotrSikora merged 3 commits intoproxy-wasm:masterfrom Oct 29, 2020
Merged
wavm: emit stack trace when an exception happens#84PiotrSikora merged 3 commits intoproxy-wasm:masterfrom
PiotrSikora merged 3 commits intoproxy-wasm:masterfrom
Conversation
Signed-off-by: mathetake <takeshi@tetrate.io>
mathetake
commented
Oct 28, 2020
Contributor
Author
|
blocker: #49 We couldn't tell even if this compiles though I've already tested in my local machine. Before we merge this PR, I will write WAVM tests, and then test this PR |
PiotrSikora
requested changes
Oct 29, 2020
Member
PiotrSikora
left a comment
There was a problem hiding this comment.
I don't think we need to block this on tests in this repo if you can open a PR in Envoy to make sure that this doesn't break anything.
Signed-off-by: mathetake <takeshi@tetrate.io>
PiotrSikora
requested changes
Oct 29, 2020
Signed-off-by: mathetake <takeshi@tetrate.io>
PiotrSikora
approved these changes
Oct 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR emits call stack trace when exception happens in WAVM just like V8 (#66)
this requires a change in the WAVM library used in Envoy: envoyproxy/envoy#13792
Signed-off-by: mathetake takeshi@tetrate.io