Fix for V8 build on s390x. (#197)#214
Conversation
Signed-off-by: Konstantin Maksimov <konstantin.maksimov@ibm.com>
Thanks! I've added it to the CL upstream (https://chromium-review.googlesource.com/c/v8/v8/+/3346395).
Thanks, this one is already in the CL upstream and in my testing branch here (#211). I didn't update it on the Quick question. How did you get Bazel on s390x working? I've spent the last few days trying to build it under QEMU (to verify the V8 CL and your fix in #198), but it keeps crashing during build. |
|
OK, I regenerated patches in #211 on top of V8's |
...and of course, right after I wrote this, I managed to build it! |
|
Superseded by #216, since all patches were already merged upstream. |
This fix enables build with v8 on s390x.
Too many diffs because it is a patch of a patch. The real changes for bazel/defs.bzl are: