Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Cosmos-SDK to v0.45.4-pio-2 (from v0.45.4-pio-1) (release/v1.11.x) #928

Merged
merged 3 commits into from
Jul 13, 2022

Conversation

dwedul-figure
Copy link
Contributor

Description

Bump Cosmos-SDK to v0.45.4-pio-2 (from v0.45.4-pio-1) to fix a non-deterministic map iteration.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@dwedul-figure dwedul-figure enabled auto-merge (squash) July 12, 2022 21:44
@dwedul-figure dwedul-figure changed the title Bump Cosmos-SDK to v0.45.4-pio-2 (from v0.45.4-pio-1) Bump Cosmos-SDK to v0.45.4-pio-2 (from v0.45.4-pio-1) (release/v1.11.x) Jul 12, 2022
@dwedul-figure dwedul-figure disabled auto-merge July 12, 2022 21:52
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #928 (493658d) into release/v1.11.x (e23fde9) will increase coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head 493658d differs from pull request most recent head 21fc589. Consider uploading reports for the commit 21fc589 to get more accurate results

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v1.11.x     #928      +/-   ##
===================================================
+ Coverage            56.20%   56.23%   +0.03%     
===================================================
  Files                  181      181              
  Lines                22254    22244      -10     
===================================================
+ Hits                 12507    12509       +2     
+ Misses                8790     8778      -12     
  Partials               957      957              
Impacted Files Coverage Δ
app/upgrades.go 14.08% <0.00%> (+4.20%) ⬆️
x/msgfees/types/params.go 43.39% <ø> (ø)

@dwedul-figure dwedul-figure enabled auto-merge (squash) July 12, 2022 21:52
derekadams
derekadams previously approved these changes Jul 13, 2022
@dwedul-figure dwedul-figure disabled auto-merge July 13, 2022 22:13
arnabmitra
arnabmitra previously approved these changes Jul 13, 2022
Copy link
Contributor

@arnabmitra arnabmitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dwedul-figure dwedul-figure dismissed stale reviews from arnabmitra and derekadams via 21fc589 July 13, 2022 22:19
@dwedul-figure dwedul-figure enabled auto-merge (squash) July 13, 2022 22:19
@dwedul-figure dwedul-figure merged commit 1dd868e into release/v1.11.x Jul 13, 2022
@dwedul-figure dwedul-figure deleted the dwedul/v1.11.1-rc4-w-fix branch July 13, 2022 22:27
dwedul-figure added a commit that referenced this pull request Jul 14, 2022
* add upgrade handler. fix lint errors. update changelog version

* separate changelog sections for v1.11.0 -> v1.11.1-rc1 updates

* Improve markdown for changelog entries

Co-authored-by: Daniel Wedul <[email protected]>

* Add new param setting in upgrade handler  (#875) (#877)

* Add new upgrade handler, Clean up unused upgrade method and tests

* Add changelog

* Upgrade comment

* Update nhash per usd for 0.04 hash price

(cherry picked from commit acbe656)

* Create Mango rc2 handler. (#888)

* Move the mango upgrade to mango-rc2 and add an empty mango upgrade since that's what actually happened for v1.11.1-rc1.

* Add changelog entry.

* Keep the code in the original mango upgrade (as well a the mango-rc2 upgrade).

* Clarify changelog entry.

* Fix changelog entry.

* add changelog header for v1.11.1-rc2 (#889)

* Add mango-rc4 hanlder (#895)

* Add mango-rc4 handler to actuall do the module migrations.

* Fill in PR number and linkify it.

* Update the mango handler to also run the migrations.

* Clean up the Mango RC upgrade handlers. (#901)

* Remove the mango-rc2 and -rc4 upgrade handlers. The logic in there is already replicated in the mango handler.

* remove an empty line in the hopes that this push triggers the github actions.

* Try to get the AC_USERNAME

* Try 2 of getting the username.

* Try swapping the ac username and password.

* Don't print out the stuff.

* Unswap the username/password since that's supposedly fixed.

* Clean up the CHANGELOG to combine the RC entries.

* Put more details in the changelog. These new lines reflect what's already in main.

* Update release date.

* Update date in changelog.

* Add empty upgrade handler for mango-rc4 so that this can still run testnet.

* Bump Cosmos-SDK to v0.45.4-pio-2 (from v0.45.4-pio-1) (release/v1.11.x) (#928)

* Update Cosmos-SDK version to v0.45.4-pio-2 (from v0.45.4-pio-1).

* Add PR link to changelog.

Co-authored-by: Derek Adams <[email protected]>
Co-authored-by: Carlton Hanna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants