-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Cosmos-SDK to v0.45.4-pio-2 (from v0.45.4-pio-1) (release/v1.11.x) #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwedul-figure
requested review from
iramiller,
nullpointer0x00,
arnabmitra,
derekadams,
egaxhaj and
Taztingo
as code owners
July 12, 2022 21:44
dwedul-figure
changed the title
Bump Cosmos-SDK to v0.45.4-pio-2 (from v0.45.4-pio-1)
Bump Cosmos-SDK to v0.45.4-pio-2 (from v0.45.4-pio-1) (release/v1.11.x)
Jul 12, 2022
Codecov Report
@@ Coverage Diff @@
## release/v1.11.x #928 +/- ##
===================================================
+ Coverage 56.20% 56.23% +0.03%
===================================================
Files 181 181
Lines 22254 22244 -10
===================================================
+ Hits 12507 12509 +2
+ Misses 8790 8778 -12
Partials 957 957
|
derekadams
previously approved these changes
Jul 13, 2022
arnabmitra
previously approved these changes
Jul 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
# Conflicts: # CHANGELOG.md
dwedul-figure
dismissed stale reviews from arnabmitra and derekadams
via
July 13, 2022 22:19
21fc589
derekadams
approved these changes
Jul 13, 2022
egaxhaj
approved these changes
Jul 13, 2022
dwedul-figure
added a commit
that referenced
this pull request
Jul 14, 2022
* add upgrade handler. fix lint errors. update changelog version * separate changelog sections for v1.11.0 -> v1.11.1-rc1 updates * Improve markdown for changelog entries Co-authored-by: Daniel Wedul <[email protected]> * Add new param setting in upgrade handler (#875) (#877) * Add new upgrade handler, Clean up unused upgrade method and tests * Add changelog * Upgrade comment * Update nhash per usd for 0.04 hash price (cherry picked from commit acbe656) * Create Mango rc2 handler. (#888) * Move the mango upgrade to mango-rc2 and add an empty mango upgrade since that's what actually happened for v1.11.1-rc1. * Add changelog entry. * Keep the code in the original mango upgrade (as well a the mango-rc2 upgrade). * Clarify changelog entry. * Fix changelog entry. * add changelog header for v1.11.1-rc2 (#889) * Add mango-rc4 hanlder (#895) * Add mango-rc4 handler to actuall do the module migrations. * Fill in PR number and linkify it. * Update the mango handler to also run the migrations. * Clean up the Mango RC upgrade handlers. (#901) * Remove the mango-rc2 and -rc4 upgrade handlers. The logic in there is already replicated in the mango handler. * remove an empty line in the hopes that this push triggers the github actions. * Try to get the AC_USERNAME * Try 2 of getting the username. * Try swapping the ac username and password. * Don't print out the stuff. * Unswap the username/password since that's supposedly fixed. * Clean up the CHANGELOG to combine the RC entries. * Put more details in the changelog. These new lines reflect what's already in main. * Update release date. * Update date in changelog. * Add empty upgrade handler for mango-rc4 so that this can still run testnet. * Bump Cosmos-SDK to v0.45.4-pio-2 (from v0.45.4-pio-1) (release/v1.11.x) (#928) * Update Cosmos-SDK version to v0.45.4-pio-2 (from v0.45.4-pio-1). * Add PR link to changelog. Co-authored-by: Derek Adams <[email protected]> Co-authored-by: Carlton Hanna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump Cosmos-SDK to v0.45.4-pio-2 (from v0.45.4-pio-1) to fix a non-deterministic map iteration.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes