Put the wasm dir back in wasm/wasm. #2071
Conversation
WalkthroughThe recent update to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- app/app.go (1 hunks)
Additional comments not posted (2)
app/app.go (1)
623-623: LGTM! But verify the new path usage in the codebase.The code changes are approved.
However, ensure that all references to the old path are updated to the new path containing the additional "wasm" directory.
Verification successful
Verification Successful: No further updates needed.
The new path
filepath.Join(homePath, "data", "wasm")is correctly updated and referenced only inapp/app.go. No other references to the old path or similar directories were found that require updating.
app/app.go: The only file referencing the updated path.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to the old wasmDir path are updated to the new path. # Test: Search for the old path usage. Expect: No occurrences of the old path. rg --type go 'filepath.Join\(homePath, "data"\)'Length of output: 50
Script:
#!/bin/bash # Description: Verify all references to the new wasmDir path. # Test: Search for the new path usage. Expect: Occurrences of the new path. rg --type go 'filepath.Join\(homePath, "data", "wasm"\)'Length of output: 121
Script:
#!/bin/bash # Description: Verify any other potential references to directories similar to the old path. # Test: Search for any references to "data" directory that might need updating. rg --type go 'filepath.Join\(homePath, "data"\)'Length of output: 50
Script:
#!/bin/bash # Description: Verify any references to "wasm" directories to ensure all relevant paths are updated. # Test: Search for any references to "wasm" directories. rg --type go 'wasm'Length of output: 43779
CHANGELOG.md (1)
50-53: LGTM!The entry clearly describes the bug fix related to relocating the
wasmdirectory.
* Put the wasm dir back in wasm/wasm. * Add changelog entry.
* Put the wasm dir back in wasm/wasm. * Add changelog entry. Co-authored-by: Ira Miller <[email protected]>
Description
Put the wasm directory back to
data/wasm/wasm. That is what it is inv1.18(and before).Yesterday, I worked on adding a step to the upgrade that would move the directory, but that comes with complications that would be better to not rush. Specifically, during the app initialization, the wasm module creates some stuff in there (if it doesn't already exist). And it looks like there's some new stuff in there. So we'd have to do some sort of merger of the old and new, and do it in a way that, upon a failure, doesn't really screw things up for people.
We can try to move it again later, when we've got more time to evaluate the sticking points and get some decent testing on it first.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passesSummary by CodeRabbit
Bug Fixes
wasmdirectory.Documentation
Chores
github.com/hashicorp/go-getter.