Add the Sanction Module #1922
Merged
Add the Sanction Module #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…more and fix some types that moved.
…stuff directly instead of using .Walk on all props.
…eper so that I can still mock proposals.
…regenerate later, but this is a quick fix).
…anction stuff (will do the rest later after this gets in, I guess). Also make generic funcs for the --authority flag. Fix uses of simState.AppParams.GetOrGenerate.
…stead of the most recent one.
…od since its not needed anymore.
…n cli tests compile (using the new helpers).
…make some helpers for getting the codec stuff.
…d times much, much better.
…t I can log more stuff and make it easier to debug problems.
|
Important Auto Review SkippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 25 files out of 90 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
…s. Add TOCs to the sanction docs, fix the proto links, and do a little cleanup.
# Conflicts: # app/navs_mainnet.go # app/navs_mainnet_tourmaline.go # app/navs_testnet.go
Taztingo
approved these changes
Apr 10, 2024
SpicyLemon
commented
Apr 10, 2024
nullpointer0x00
approved these changes
Apr 10, 2024
|
This was part of: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Copy the sanction module from our SDK fork and add it back into our app.
Excitingly, all the unit tests in the sanction module pass too, including the CLI ones. This PR adds some generic helpers that we'll be able to use for other CLI unit tests that we still need to fix.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes