Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quicksilver upgrades and add saffron #1648

Merged
merged 5 commits into from
Aug 11, 2023
Merged

Conversation

SpicyLemon
Copy link
Contributor

@SpicyLemon SpicyLemon commented Aug 11, 2023

Description

Remove the quicksilver upgrades and add ones for saffron with just the standard upgrade stuffs.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@SpicyLemon SpicyLemon requested a review from a team as a code owner August 11, 2023 18:48
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #1648 (98bfdf9) into main (60edc7d) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1648      +/-   ##
==========================================
+ Coverage   63.81%   63.83%   +0.01%     
==========================================
  Files         223      223              
  Lines       28599    28587      -12     
==========================================
- Hits        18251    18249       -2     
+ Misses       9156     9145      -11     
- Partials     1192     1193       +1     
Files Changed Coverage Δ
x/attribute/keeper/keeper.go 77.65% <ø> (+0.21%) ⬆️
x/marker/keeper/marker.go 55.53% <ø> (-0.51%) ⬇️
app/upgrades.go 63.58% <66.66%> (+4.69%) ⬆️

@iramiller iramiller merged commit 588a454 into main Aug 11, 2023
@iramiller iramiller deleted the dwedul/remove-quicksilver branch August 11, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants