Add upgrade handlers for rust-rc1 and rust. #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng now: The owner seems to have abandoned the linter. Replaced by unused.
… standard logging around the module migrations.
…e gov v1 MsgSubmitProposal fee in the rust upgrades.
SpicyLemon
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1549 +/- ##
==========================================
+ Coverage 61.84% 61.95% +0.11%
==========================================
Files 198 198
Lines 25586 25611 +25
==========================================
+ Hits 15823 15868 +45
+ Misses 8661 8637 -24
- Partials 1102 1106 +4
|
nullpointer0x00
previously approved these changes
May 17, 2023
# Conflicts: # CHANGELOG.md
… since the plan doesn't provide any usable info, but we regularly need to get that version map. Just create the noopHandler function in the loop the same way we create the non-no-op one. Add a log message about the upgrade starting. Rename the map to upgrades (from handlers) since they're defining more than just handlers.
…lizeContractFee, on the rust and rust-rc1 upgrades and also some testing on the keys defined in the upgrades map. Move the log buffer stuff to the suite level.
…tests can create an app without interference from those tests.
iramiller
previously approved these changes
May 18, 2023
Heh. It was picked partially for that reference. Also not to be confused with the book or soon-to-be-movie. |
Taztingo
approved these changes
May 19, 2023
iramiller
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the
pauaandpaua-rc2upgrades and stuff specific to those upgrades.Add upgrade handlers for
rust-rc1andrust. Therust-rc1upgrade will create a gov v1MsgSubmitProposalmessage fee (if it doesn't already exist). Both upgrades will delete theMsgP8eMemorializeContractRequestmessage fee since that message no longer exists.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes