Update the paua upgrades to set the sanction params. #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nullpointer0x00
previously approved these changes
Feb 3, 2023
iramiller
reviewed
Feb 3, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1345 +/- ##
==========================================
- Coverage 58.92% 58.87% -0.06%
==========================================
Files 197 197
Lines 24844 24867 +23
==========================================
Hits 14640 14640
- Misses 9110 9133 +23
Partials 1094 1094
|
|
Had to tweak it. |
4 tasks
|
I've tested this on a local chain (e.g. |
iramiller
approved these changes
Feb 6, 2023
llama-del-rey
approved these changes
Feb 6, 2023
SpicyLemon
added a commit
that referenced
this pull request
Feb 6, 2023
* Update the paua upgrades to set the sanction params. * Run the migrations before attempting to set the sanciton params. * Fix lint errors about reuse of err. * Remove duplicated piece that I forgot to replace earlier. * Run migrations first in the upgrade. * Don't increase max gas in paua (mainnet), at least for now.
8 tasks
iramiller
added a commit
that referenced
this pull request
Feb 6, 2023
* Update the paua upgrades to set the sanction params. * Run the migrations before attempting to set the sanciton params. * Fix lint errors about reuse of err. * Remove duplicated piece that I forgot to replace earlier. * Run migrations first in the upgrade. * Don't increase max gas in paua (mainnet), at least for now. Co-authored-by: Ira Miller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the
paua-rc1andpauaupgrades to set the sanction module's params.Immediate sanction and unsanction require a 1,000,000 hash deposit.
This PR also updates the
paua(mainnet) upgrade to NOT increase the max gas per block. That increase is still in thepaua-rc1upgrade though.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes