Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add voting/non-voting validator list to validatorsAtHeight API #183

Closed
8 tasks
ghost opened this issue Jul 21, 2021 · 0 comments · Fixed by #228
Closed
8 tasks

Feature: Add voting/non-voting validator list to validatorsAtHeight API #183

ghost opened this issue Jul 21, 2021 · 0 comments · Fixed by #228
Assignees
Labels
api Adding/updating an API enhancement New feature or request good first issue Good for newcomers service functionality Improving functionality at the service level. May affect any area of the project
Milestone

Comments

@ghost
Copy link

ghost commented Jul 21, 2021

Summary

Currently the validators at height list for a block shows all validators in the set at the height, but not who voted/didnt vote, even though the block detail shows a count of who voted vs validator set count. It would be nice to see which validators voted/not voted.

Problem Definition

Currently the validators at height list for a block shows all validators in the set at the height, but not who voted/didnt vote, even though the block detail shows a count of who voted vs validator set count. It would be nice to see which validators voted/not voted.

Proposal

Option 1:

  • Gather a list of the validators that voted
  • Add the list to API api/v2/validators/height/{height} response

Option 2:

  • Add whether the validator voted to the validator object returned from api/v2/validators/height/{height}
    • voted: Boolean

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ghost ghost added enhancement New feature or request good first issue Good for newcomers api Adding/updating an API service functionality Improving functionality at the service level. May affect any area of the project labels Jul 21, 2021
@ghost ghost added this to the v2.3.0 milestone Aug 31, 2021
ghost pushed a commit that referenced this issue Aug 31, 2021
* Added block latency api for validator
* Added vote and proposer data for validator at height set
* Fixed validator votes vs validator set for spotlight data

closes: #199
closes: #183
@ghost ghost closed this as completed in #228 Aug 31, 2021
ghost pushed a commit that referenced this issue Aug 31, 2021
* Added block latency api for validator
* Added vote and proposer data for validator at height set
* Fixed validator votes vs validator set for spotlight data

closes: #199
closes: #183
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Adding/updating an API enhancement New feature or request good first issue Good for newcomers service functionality Improving functionality at the service level. May affect any area of the project
Projects
Status: Release v2.3.0
Development

Successfully merging a pull request may close this issue.

1 participant