Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ jobs:
CSC_KEY_PASSWORD: ${{ secrets.WINDOWS_CERTIFICATE_PASSWORD }}
# Publishing is this workflow's job, not electron-builder's.
GH_TOKEN: ""
run: pnpm --filter "@project-wiki/desktop" run package
run: pnpm --filter "@open-wiki/desktop" run package

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Expect apps/desktop/package.json to declare `@open-wiki/desktop`.
fd -t f package.json . | xargs -r rg -n '"name": "@(open-wiki|project-wiki)/desktop"'

# Review old-name hits. Historical changelog prose may remain; active metadata,
# workflows, scripts, and links must use the new names.
rg -n --hidden -g '!.git' \
  '"name": "project-wiki"|`@project-wiki/`|plans/project-wiki\.md' .

Repository: protonspy/open-wiki

Length of output: 161


🏁 Script executed:

#!/bin/bash
set -u

printf '%s\n' '--- desktop package manifests ---'
fd -t f -i 'package.json' . | while IFS= read -r f; do
  if rg -q '"name"[[:space:]]*:[[:space:]]*"(`@open-wiki`|`@project-wiki`)/desktop"' "$f"; then
    rg -n '"name"[[:space:]]*:[[:space:]]*"(`@open-wiki`|`@project-wiki`)/desktop"' "$f"
    printf 'file: %s\n' "$f"
  fi
done

printf '%s\n' '--- workspace package names and filter references ---'
rg -n --hidden -g '!.git' \
  '"name"[[:space:]]*:[[:space:]]*"(`@open-wiki`|`@project-wiki`)/desktop"|`@open-wiki/desktop`|`@project-wiki/desktop`|filter' .

printf '%s\n' '--- workflow context ---'
cat -n .github/workflows/release.yml | sed -n '65,85p'

Repository: protonspy/open-wiki

Length of output: 1861


🏁 Script executed:

#!/bin/bash
set -u

printf '%s\n' '--- repository files relevant to workspace metadata ---'
git ls-files | rg '(^|/)(package\.json|pnpm-workspace\.yaml|pnpm-lock\.yaml|release\.yml)$|desktop'

printf '%s\n' '--- all package manifest names ---'
fd -t f -i 'package.json' . | while IFS= read -r f; do
  printf 'file: %s\n' "$f"
  rg -n '"name"[[:space:]]*:' "$f" | head -n 5
done

printf '%s\n' '--- exact active old-scope references ---'
rg -n --hidden -g '!.git' '`@project-wiki/`|plans/project-wiki\.md|"name"[[:space:]]*:[[:space:]]*"project-wiki' . || true

Repository: protonspy/open-wiki

Length of output: 425


🏁 Script executed:

#!/bin/bash
set -u

printf '%s\n' '--- workspace configuration ---'
cat -n pnpm-workspace.yaml
printf '%s\n' '--- root package manifest ---'
cat -n package.json
printf '%s\n' '--- workspace package discovery script ---'
cat -n scripts/ci/workspace-packages.mjs | sed -n '1,115p'
printf '%s\n' '--- desktop paths tracked or present ---'
git ls-files apps/desktop
find apps/desktop -maxdepth 2 -type f -print 2>/dev/null | sort || true
printf '%s\n' '--- ignore rules relevant to desktop ---'
rg -n 'desktop|package\.json|apps' .gitignore .git/info/exclude 2>/dev/null || true

Repository: protonspy/open-wiki

Length of output: 5089


Add apps/desktop/package.json with "name": "@open-wiki/desktop" before using this filter. The workspace has no desktop package manifest, so pnpm cannot resolve the filter and the installer build fails.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/release.yml at line 77, Add the missing apps/desktop
package manifest with the package name set to `@open-wiki/desktop` before the
release workflow invokes the pnpm filter in the desktop packaging step, so the
workspace can resolve that filter successfully.


- name: Collect the artifacts and their checksums
id: collect
Expand Down
Loading
Loading