Add usage support for power joins v3 #549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! As of v1.4.17, only v3 is supported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, I want to say it was a nice surprise to see the support for sorting the table component using Power Joins!
This PR is coming after this issue that was opened in the power joins repo directly. After a bit of digging, I saw that the package is using and checking the methods from v2, while we have some different ways of handling this on v3.
I believe we can make v2 or v3 work, depending only on what the user has installed. I pushed this PR with an attempt to solve this, but I wasn't able to actually test this yet. Do you have an easy way to verify if this is working? Otherwise, I'll try to create a demo project to make sure this is working.