Skip to content

Conversation

@0PandaDEV
Copy link

No description provided.

@wipfli
Copy link
Collaborator

wipfli commented Apr 25, 2025

Thanks! Can you share some before / after screenshots?

@0PandaDEV
Copy link
Author

Sure, I tested it on basemaps flavours

Before

image

After

image

@wipfli
Copy link
Collaborator

wipfli commented Apr 25, 2025

I like the colors your propose. But maybe it should be more the dark style rather than the grayscale style that we change?

@0PandaDEV
Copy link
Author

@wipfli Yes, but then I could argue that the current grayscale is more like a light mode instead of gray :)

@bdon
Copy link
Member

bdon commented May 5, 2025

This is changing one of the default flavors to a fundamentally different appearance.

The https://github.com/protomaps/basemaps-flavors is intended as a namespace for third-party contributed themes. It isn't built yet, but is intended to have open contributions as long as you 1) provide a flavor that is sufficiently different from existing ones and 2) give your flavor a unique name. Does that better meet your goals for this contribution?

@0PandaDEV
Copy link
Author

@bdon Yes I did actually test the color scheme I made here with basemaps-flavors the problem is that I can't use that currently in production and I don't know how I can generate a standardized style.json like this https://api.protomaps.com/styles/v5/dark/en.json?key=41d0bb6a6d7f132e.

@bdon
Copy link
Member

bdon commented May 21, 2025

Hi @0PandaDEV

with @protomaps/basemaps v5.4.0 you can now do this:

npm install @protomaps/basemaps
npx generate_style out.json https://example.com/tiles.json flat.ts en

That will output the full style to out.json

flat can also be a JS ES6 module or a JSON

Let me know if that works for your use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants