Merged
Conversation
protolambda
reviewed
Jun 23, 2022
Contributor
Author
|
Hey @protolambda, I added the preset files but none of the functionality, the only reason we need this in hive is because nimbus complains if the Capella fork and epoch are not present in the yaml files. Let me know if that's ok. Thanks! |
marioevz
force-pushed
the
add-capella
branch
from
7097c0f to
3c2e999
Compare
marioevz
changed the title
Contributor
Author
|
Latest commit fully implements Capella, but some of the tests are still failing, I need to debug further. |
Owner
|
Implemented a bunch of fixes, but the ssz serialization of BeaconBlockBody (and all types it is contained in) is still failing, so I missed something there. Will continue later today. |
Owner
|
Made more fixes + added test runners and updated test fork settings. All tests are passing now, including new Capella tests. Thank you for contributing a lot of the Capella functionality here 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the default fork version and epoch for capella fork, from ethereum/consensus-specs
, as well as other placeholders for the fork information.
Currently required on hive tests to be able to start eth2/engine simulator with Nimbus beacon node.