fixes & cleanup - #28
Conversation
protolambda
left a comment
protolambda
left a comment
There was a problem hiding this comment.
Not sure where the spec of this code is, but the code is missing a signature domain for safety. You may want to update the spec with something like this.
| HashTreeRoot() ([32]byte, error) | ||
| } | ||
|
|
||
| func VerifySignature(obj HashTreeRoot, pk, s []byte) (bool, error) { |
There was a problem hiding this comment.
It would be much better to define the signing API in a way where you are forced to include a signing domain and fork version etc. Signatures should be constructed in a way where they are unique for the purpose of the work and version of the protocol. See compute_signing_root and get_domain in the phase0 beacon spec. You essentially want to compute a "domain" (32 bytes) from a fork digest (constructed from genesis + fork info) and a type-domain (e.g. proposals and attestations have different domains to be sure they never have the same signature for two different intents). Or you can implement your own non-standard domain method. But definitely don't just create a BLS signature over data that might have a different meaning later on in the protocol. cc @lightclient
There was a problem hiding this comment.
Also relevant: ethereum/consensus-specs#2884 for the domain
There was a problem hiding this comment.
The current validation code is already merged, in this PR it's just moved. Maybe we should transfer this into it's own issue and make an update independent to this PR, which just complements the code currently in master.
lightclient
left a comment
lightclient
left a comment
There was a problem hiding this comment.
It seems a little weird to use hexutil.Bytes for extra_data since it is a fixed 32 byte value, like many values already in the header. Okay for now though.
|
(oops, I see your msg now about |
Yeah i wrote to you before, if we use a fixed size then the block hashes don't match, because go-ethereum uses a variable width byte array. |
3 participants
Cleanup of #26 (addresses all the review comments)