Datablob transactions #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement `DATAHASH` opcode and sharding fork
…danksharding EIP)
|
@terencechain 5fa43da fixes the build issue, and I updated some more of the signer api to build blob transactions. It builds, but still experimental. The surface area to create/sign new transactions is huge, there is a lot to update. |
…ver on array blob type
…lication-layer detail, update tests. And make kzg tests run precompiles.
asn-d6
reviewed
Mar 17, 2022
| var tmpFr bls.Fr | ||
| for i := 0; i < params.FieldElementsPerBlob; i++ { | ||
| bls.MulModFr(&tmpFr, &blob[i], randomScalar) | ||
| bls.AddModFr(&batch.aggregateBlob[i], &batch.aggregateBlob[i], &tmpFr) |
There was a problem hiding this comment.
Naming nitpick: s/aggregateBlob/aggregateScalar
It's not actually a single blob that is aggregated in every aggregateBlob scalar; it's actually all the blobs.
We previously computed it in UnmarshalBinary() but in a wrong way (we considered the wrapped data as part of the inner length)
Fix a bunch of bugs found during development of EIP-4844 tooling
|
More updates here: https://github.com/mdehoog/go-ethereum/tree/eip-4844 |
protolambda
pushed a commit
that referenced
this pull request
Sep 16, 2022
Use minimal transaction format as block codec
protolambda
added a commit
that referenced
this pull request
Sep 16, 2022
protolambda
added a commit
that referenced
this pull request
Jan 4, 2023
protolambda
added a commit
that referenced
this pull request
Mar 3, 2023
This commit squashes the op-geth fork history into a more maintainable diff for rebasing upon upstream geth. reference-optimistic-geth changes (origins of op-geth in early Bedrock development stage): - Deposit TX Type - Enable deposit tx in EVM/tx pool - Change deposit nonce to not be the max nonce - Extend PayloadAttributesV1 with a Transactions field - Force deposits at the start of each L2 block - Fix height check - noTxPool flag, reproduce block in verifier mode without tx pool interference - Fix RPC json marshalling (ref op-geth PR 4) - Deposit txs block height check in block body validation (ref op-geth PR 5) - core: do not try to reinject deposit txs into tx-pool (ref-op-geth PR 6) - deposit source hash field instead of L2 block height and tx index combination - Include invalid deposits, rewind state, but always persist mint (ethereum#10) - Provide gas to Call/Create in deposit transactions (ethereum#12) - Add docker builds (ref-op-geth PR 16, 17) - Don't panic on deposit transaction signature values or chain ID (ref-op-geth PR 18) - core: Add version to DepositTx (ref-op-geth PR 19) - Enable Geth build/lint/test in CircleCI (ref-op-geth PR 23) - core: Include guaranteed gas in the gas pool (ref-op-geth PR 21) - core: handle base fee, l1 availability fee, tx fee (ref-op-geth PR 27) - fix: deposit tx hash - fix l1 fee cache, rpc, tracing and tx pool - core: remove deposit-tx sub-type (a.k.a. deposit version byte) - eth/catalyst: allow engine user to reorg own chain - miner: restore ability to reorg deep as block builder - params: print Optimism consensus type in banner - core/types: remove unused protected() method, see upstream PR 23376 - core: do not mutate original balance value in tx pool l1 cost adjustment - core: subtract deposit gas from pool, so other txs do not use the same gas. And fail tx processing if deposits reach gas limit - core/types: deposits do not tip, avoid basefee subtraction - Unmeter the L1 Attributes Transaction - miner: handle force tx errors as critical, clean up diff - ci: Switch branch - eth,miner: return STATUS_INVALID when failing to process forced transactions in request (ref-op-geth PR 40) - verifier: forward tx to sequencer based on flag - txpool: add flag to disable tx gossip (ref-op-geth PR 42) - Add op-geth version in addition to geth version (ref-op-geth PR 43) - ci: CircleCI improvements (ref-op-geth PR 44) - Rename to op-geth - Build latest tag on optimism branch op-geth changes: - Expose cache config in simulated backend (#2) - Add EIP-1559 parameters - eth/catalyst: update payload id computation (#1) - make eip1559 configurable (#4) - post-merge network should not log warnings about missing transition information (#5) - Make the simulator more configurable (ethereum#6) - fix OPB-6 - IsDepositTx check instead of artificial nonce value check (ethereum#7) - Simulated backend - enable proof of stake consensus type and fix performance issue (ethereum#8) - accounts: simulated backend consensus engine option and immediate tx indexing - consensus/beacon: recognize all blocks as reached TTD with 0 TTD in chain config - Add --rollup.historicalhttp CLI flag and fix backend iface - Flags and interfaces for historical RPC requests (ethereum#12) - Redirect historical RPC requests (ethereum#13) - Use the pre-existing ethereum.NotFound error (ethereum#18) - Add historical endpoint to TraceBlockByNumber and TraceBlockByHash (ethereum#19) - Add historical endpoint to TraceTransaction (ethereum#20) - Add historical endpoint to TraceCall (ethereum#21) - optimism: fee params from info txi, update l1 cost func GPO params read (ethereum#15) - add hardcoded addresses for fee payouts (ethereum#23) - dynamic gas limit via engine API (ethereum#22) Co-authored-by: Matthew Slipper <[email protected]> Co-authored-by: Joshua Gutow <[email protected]> Co-authored-by: protolambda <[email protected]> Co-authored-by: Mark Tyneway <[email protected]> Co-authored-by: Maurelian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tracks the Datablob Eth-Denver diff (building on
base, v1.10.16)*Transaction.inner, and encode minimal (for blocks) vs wrapped (default, used in storage, tx pool, journal etc.).ExecutionPayloadresponse may make more sense)getBlobsBundleV1as proposed in execution APIs repoBlob/KZGCommitment/BLSFieldElementtypes text encoding/decoding. (andBlobis array type now)Parse()methods onBlobs/Blob/KZGCommitments/KZGCommitmentkzg.VerifyBlobs(commitments, blobs)for efficient batch verification.kzg.BlobsBatchto run same batch verification, but aggregate on the fly, to handle batching of many txsConsensus layer: