Fix some UBSAN warnings.#5901
Merged
acozzette merged 2 commits intoprotocolbuffers:masterfrom Apr 1, 2019
Merged
Conversation
* external/com_google_protobuf/src/google/protobuf/stubs/strutil.cc:1122:9: runtime error: negation of -9223372036854775808 cannot be represented in type 'google::protobuf::int64' (aka 'long'); cast to an unsigned type to negate this value to itself * Bad external/com_google_protobuf/src/google/protobuf/text_format.cc:1320:14: runtime error: null pointer passed as argument 1, which is declared to never be null /usr/include/string.h:62:62: note: nonnull attribute specified here Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
added a commit
to htuch/oss-fuzz
that referenced
this pull request
Mar 15, 2019
Fix in progress at protocolbuffers/protobuf#5901, we might not update Envoy with it for a while. Signed-off-by: Harvey Tuch <htuch@google.com>
inferno-chromium
pushed a commit
to google/oss-fuzz
that referenced
this pull request
Mar 19, 2019
Fix in progress at protocolbuffers/protobuf#5901, we might not update Envoy with it for a while. Signed-off-by: Harvey Tuch <htuch@google.com>
|
@htuch If you don't mind could you either rebase this onto master or merge master into your branch? The Linux Ruby 2.6 test shows a strange crash. I don't see how it could be related to this pull request but maybe it's a separate issue that has since been fixed. For the other test failure (MacOS Ruby 2.3), let's not worry about that because I have a separate fix that just needs to be merged. |
Contributor
Author
|
@aconchillo done |
|
Thanks @htuch! |
htuch
added a commit
to htuch/envoy
that referenced
this pull request
Apr 26, 2019
Since envoyproxy#6610 the fuzzer build has been broken. This is due to the interaction of rules_foreign_cc external dependencies and the additional UBSAN blacklist maintained by the oss-fuzz driver to workaround the fact we don't have protocolbuffers/protobuf#5901 yet. Thir PR moves protocolbuffers/protobuf#5901 into Envoy proper and hence we don't need an UBSAN blacklist in the oss-fuzz driver anymore. Risk level: Low Tesitng: oss-fuzz Docker build. Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
added a commit
to envoyproxy/envoy
that referenced
this pull request
Apr 26, 2019
Since #6610 the fuzzer build has been broken. This is due to the interaction of rules_foreign_cc external dependencies and the additional UBSAN blacklist maintained by the oss-fuzz driver to workaround the fact we don't have protocolbuffers/protobuf#5901 yet. This PR moves protocolbuffers/protobuf#5901 into Envoy proper and hence we don't need an UBSAN blacklist in the oss-fuzz driver anymore. Risk level: Low Tesitng: oss-fuzz Docker build. Signed-off-by: Harvey Tuch <htuch@google.com>
jeffpiazza-google
pushed a commit
to jeffpiazza-google/envoy
that referenced
this pull request
May 3, 2019
Since envoyproxy#6610 the fuzzer build has been broken. This is due to the interaction of rules_foreign_cc external dependencies and the additional UBSAN blacklist maintained by the oss-fuzz driver to workaround the fact we don't have protocolbuffers/protobuf#5901 yet. This PR moves protocolbuffers/protobuf#5901 into Envoy proper and hence we don't need an UBSAN blacklist in the oss-fuzz driver anymore. Risk level: Low Tesitng: oss-fuzz Docker build. Signed-off-by: Harvey Tuch <htuch@google.com> Signed-off-by: Jeff Piazza <jeffpiazza@google.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
external/com_google_protobuf/src/google/protobuf/stubs/strutil.cc:1122:9: runtime error: negation of -9223372036854775808 cannot be represented in type 'google::protobuf::int64' (aka 'long'); cast to an unsigned type to negate this value to itself
Bad external/com_google_protobuf/src/google/protobuf/text_format.cc:1320:14: runtime error: null pointer passed as argument 1, which is declared to never be null
/usr/include/string.h:62:62: note: nonnull attribute specified here
Signed-off-by: Harvey Tuch htuch@google.com